From 98eb5bf47583612f732f957a3b11a2c1d04803ec Mon Sep 17 00:00:00 2001 From: Holger Vogt Date: Fri, 25 Dec 2020 15:38:27 +0100 Subject: [PATCH] bug #537: remove memcopy with overlapping strings Bug reported by Ronan BARZIC --- src/frontend/numparam/xpressn.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/frontend/numparam/xpressn.c b/src/frontend/numparam/xpressn.c index f3379b5a7..c3cc60823 100644 --- a/src/frontend/numparam/xpressn.c +++ b/src/frontend/numparam/xpressn.c @@ -1424,13 +1424,10 @@ nupa_subcktcall(dico_t *dico, const char *s, const char *x, const char *i2 = strstr(ds_get_buf(&tstr), "params:"); if (i2) { - const char *optr, *jptr; - - pscopy(&tstr, i2 + 7, NULL); + const char* optr, * jptr; /* search identifier to the left of '=' assignments */ - - for (optr = ds_get_buf(&tstr); + for (optr = i2 + 7; (jptr = strchr(optr, '=')) != NULL; optr = jptr + 1) {