From 045de93d3b445a2cb26bc3f98fc21ba24ab796f0 Mon Sep 17 00:00:00 2001
From: rlar <rlar>
Date: Thu, 12 Nov 2015 17:57:40 +0100
Subject: [PATCH] frontend/define.c, cleanup `prtree1()'

---
 src/frontend/define.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/src/frontend/define.c b/src/frontend/define.c
index f1708f873..75c65d95f 100644
--- a/src/frontend/define.c
+++ b/src/frontend/define.c
@@ -261,11 +261,10 @@ prtree1(struct pnode *pn, FILE *fp)
 struct pnode *
 ft_substdef(const char *name, struct pnode *args)
 {
-    struct udfunc *udf;
+    struct udfunc *udf, *wrong_udf = NULL;
     struct pnode *tp;
     char *s;
-    int arity = 0, rarity = 0;
-    bool found = FALSE;
+    int arity = 0;
 
     if (args)
         arity = 1;
@@ -276,19 +275,16 @@ ft_substdef(const char *name, struct pnode *args)
 
     for (udf = udfuncs; udf; udf = udf->ud_next)
         if (eq(name, udf->ud_name)) {
-            if (arity == udf->ud_arity) {
+            if (arity == udf->ud_arity)
                 break;
-            } else {
-                found = TRUE;
-                rarity = udf->ud_arity;
-            }
+            wrong_udf = udf;
         }
 
     if (udf == NULL) {
-        if (found)
+        if (wrong_udf)
             fprintf(cp_err,
                     "Warning: the user-defined function %s has %d args\n",
-                    name, rarity);
+                    name, wrong_udf->ud_arity);
         return NULL;
     }